-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Accordion component and patterns #662
Conversation
🦋 Changeset detectedLatest commit: ba7a8db The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
site/src/components/accordion.md
Outdated
|
||
### Open | ||
|
||
There is an option to have the accordion component load in the expanded state by adding the `open` attribute to one of the items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, slight rewording, please feel free to disregard:
There is an option to have the accordion component load in the expanded state by adding the `open` attribute to one of the items. | |
To load the accordion component in the expanded state by default, add the `open` attribute to the appropriate `<details>` element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅Updated since I was already updating other copy.
…olutely positions chevron
7f0931a
to
2801fea
Compare
@ollips @BenDMyers @homing1 all feedback has been addressed. Ready for review. |
da32ace
to
0dd1fc2
Compare
5dad42b
to
9d3d573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Still need to come up with the pattern descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@homing1 @BenDMyers @ollips feedback has been addressed, ready for review.
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
Task: task-988155
Links: Accordion component | Accordion patterns
Component
http://localhost:1111/components/accordion.html
Fluent 2 - React Accordion - Fluent 2 Design System (microsoft.design)
Figma - Fluent 2 web – Figma
Accessibility - Accordion Pattern (Sections With Show/Hide Functionality) | APG | WAI | W3C
Handles:
* Automatically adds left/right padding if background color atomic classes are usedPattern
http://localhost:1111/patterns/accordion.html
Serves 2 functions
Form-based advisor/Plan adjuster pattern for Ignite
Figmas (press Shift + 2 after page load to zoom in on component selection):
_details.scss
usage in docs-ui3rd pattern example would replace:
Testing
Expected result: Component page matches Figma. Patterns match docs-ui .details usage (FAQ, Career Path Journey section), and Form-based advisor/Plan adjuster designs proposed for Ignite
Expected result: Verify refactor to use shared chevron mixin results in no visual changes from existing page
Additional information
[Optional]
Contributor checklist